From a7786e523633f59e5e2cd64db6f8903913112545 Mon Sep 17 00:00:00 2001
From: Baokun Lee <nototon@gmail.com>
Date: Fri, 20 Jul 2018 00:10:29 +0800
Subject: [PATCH] bugfix: check image parsed error

---
 cli/pull.go                 | 5 ++++-
 pkg/reference/parse_test.go | 5 +++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/cli/pull.go b/cli/pull.go
index 2b0ae860c..37f14549b 100644
--- a/cli/pull.go
+++ b/cli/pull.go
@@ -204,7 +204,10 @@ func pullMissingImage(ctx context.Context, apiClient client.CommonAPIClient, ima
 		}
 	}
 
-	namedRef, _ := reference.Parse(image)
+	namedRef, err := reference.Parse(image)
+	if err != nil {
+		return err
+	}
 	namedRef = reference.TrimTagForDigest(reference.WithDefaultTagIfMissing(namedRef))
 
 	var name, tag string
diff --git a/pkg/reference/parse_test.go b/pkg/reference/parse_test.go
index 40f03c2de..b1f0494aa 100644
--- a/pkg/reference/parse_test.go
+++ b/pkg/reference/parse_test.go
@@ -126,6 +126,11 @@ func TestParse(t *testing.T) {
 				tag:   "1669a6aa7350e1cdd28f972ddad5aceba2912f589f19a090ac",
 			},
 			err: nil,
+		}, {
+			name:     "empty input",
+			input:    "  ",
+			expected: nil,
+			err:      ErrInvalid,
 		},
 	} {
 		ref, err := Parse(tc.input)