Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] restart API has an incorrect path #991

Closed
allencloud opened this issue Mar 28, 2018 · 0 comments · Fixed by #992
Closed

[test] restart API has an incorrect path #991

allencloud opened this issue Mar 28, 2018 · 0 comments · Fixed by #992

Comments

@allencloud
Copy link
Collaborator

Ⅰ. Issue Description

recently we ran into several CI failure as the following:

FAIL: /go/src/github.com/alibaba/pouch/test/api_restart_test.go:25: APIContainerRestartSuite.TestAPIContainerRestart
/go/src/github.com/alibaba/pouch/test/api_restart_test.go:40:
    CheckRespStatus(c, resp, 204)
/go/src/github.com/alibaba/pouch/test/util_api.go:21:
    c.Assert(resp.StatusCode, check.Equals, status, check.Commentf("Error:%s", got.Message))
... obtained int = 500
... expected int = 204
... Error:container: : too many
----------------------------------------------------------------------
FAIL: /go/src/github.com/alibaba/pouch/test/api_restart_test.go:46: APIContainerRestartSuite.TestAPIRestartStoppedContainer
/go/src/github.com/alibaba/pouch/test/api_restart_test.go:49:
    CreateBusyboxContainerOk(c, cname)
/go/src/github.com/alibaba/pouch/test/util_api.go:21:
    c.Assert(resp.StatusCode, check.Equals, status, check.Commentf("Error:%s", got.Message))
... obtained int = 409
... expected int = 201
... Error:container name: TestAPIContainerRestart: already existed

In the error message we found that container: : too many and TestAPIContainerRestart: already existed are very identical.

We need to fix this.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants