Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITSMFT::Clusterer: Optionally drop huge clusters #13808

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Dec 16, 2024

@shahor02
The implementation is obvious.
Taking as example Layer0, stave 5, the difference is visible.
Before:
stave5_withHuge
After:
stave5_noHuge

There are of course much worse scenarios.
See the print of the full layer.
Before:
withhuge_layer0
After:
no_huge_layer0

Unfortunately this does not really improve much the situation with the reconstruction, as the total number of clusters does changes of orders of ~1%.

Some of the very large clusters will do the dashed clusters effect, as I was mentioning earlier (will look for an example), and there is no way of not saving them with this.

Maybe there is still good reason to keep the "development".

@mconcas mconcas requested a review from shahor02 as a code owner December 16, 2024 18:24
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mconcas mconcas force-pushed the pr_drop_huge_clusters branch from 1cefb47 to 18332e3 Compare December 16, 2024 18:26
@mconcas
Copy link
Collaborator Author

mconcas commented Dec 16, 2024

If one zooms on the cluster around row 300 in the case of the filtered ones:
stave5_zoom_noHuge

This effect is very common, and the dashing in this case is not caused by the saturation of the bandwidth.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mconcas mconcas merged commit a498560 into AliceO2Group:dev Dec 16, 2024
13 checks passed
@mconcas mconcas deleted the pr_drop_huge_clusters branch December 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants