Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in track propagation to TOF for MC #13784

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

noferini
Copy link
Collaborator

@noferini noferini commented Dec 9, 2024

This is to fix an issue for missing piece in track length for TOF.
For the moment it is applied only to MC since for DATA old calibrations have to be adjusted before to apply the fix

watchers: @chiarazampolli @njacazio @ercolessi

@noferini noferini requested a review from shahor02 as a code owner December 9, 2024 14:40
Copy link
Contributor

github-actions bot commented Dec 9, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@noferini noferini added async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2024-PbPb-apass1 async-2024-ppRef-apass1 labels Dec 9, 2024
@noferini noferini force-pushed the dev branch 3 times, most recently from 791d598 to 246b444 Compare December 11, 2024 13:43
@noferini noferini changed the title [WIP] fix in track propagation to TOF for MC fix in track propagation to TOF for MC Dec 13, 2024
@noferini
Copy link
Collaborator Author

Hi @shahor02 ,
I started the review of this PR but I didn't mark it for Pb-Pb apass1. As discussed for the moment this is needed only for MC (mainly for other data passes and in view of QM approvals).
I tested it and both results and cpu performances are fine (CPU time unchanged).
... waiting for your review
Cheers,
Francesco

@shahor02
Copy link
Collaborator

@noferini thanks, looks good, shall I merge it already?

@noferini
Copy link
Collaborator Author

Hi @shahor02
thanks!
I think it can be merged, since RelVal is already running and I assume this will not enter in Pb-Pb apass1 reco.
Let's wait also for a confirmation by @chiarazampolli or @alcaliva

@chiarazampolli chiarazampolli merged commit 7e24578 into AliceO2Group:dev Dec 16, 2024
13 checks passed
@chiarazampolli
Copy link
Collaborator

Thanks, merged.
We might cherry-pick this one or tag from the daily of 17.12 (where it will be included).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-ppRef-apass1
Development

Successfully merging this pull request may close these issues.

3 participants