Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstreamed averaging operator #242

Closed
lukem12345 opened this issue Jun 11, 2024 · 0 comments · Fixed by #243
Closed

Use upstreamed averaging operator #242

lukem12345 opened this issue Jun 11, 2024 · 0 comments · Fixed by #243
Assignees
Labels
enhancement New feature or request

Comments

@lukem12345
Copy link
Member

lukem12345 commented Jun 11, 2024

Currently, the averaging operator from 0-forms to 1-forms is copied in a few places in this codebase.

CombinatorialSpaces.jl PR 97 upstreamed this operator.

We should use the upstreamed operator since it is actively tested and maintained there.

We will lose a little bit of pedagogical value from demonstrating in the Decapodes docs how to create an operator, but this distracts from the focus of this package.

A quick search reveals about 5 separate files that should be updated:

  • Ice dynamics docs page
  • CHT example
  • CHT CUDA example
  • Budyko-Sellers-Halfar example
  • Budyko-Sellers-Halfar docs page

Projects that rely on Decapodes, such as the Veronis.jl lightning model or the FEED.jl electron dissipation model will benefit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant