Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No full-screen function on companion app #300

Closed
srodighiero opened this issue May 16, 2022 · 21 comments · Fixed by #588
Closed

No full-screen function on companion app #300

srodighiero opened this issue May 16, 2022 · 21 comments · Fixed by #588
Labels
bug Something isn't working

Comments

@srodighiero
Copy link

Did non have a chance to test it on android. Full-screen function working fine on web interface, button is missing on companion app, while sound and play/pause buttons are present and working

@cbroissa-github
Copy link

I have the same problem with IOS, with ui: true
There is no full screen button.
0D926ECF-C39C-485C-B0A3-3AA6DB9E35B6

@AlexxIT AlexxIT added the bug Something isn't working label May 20, 2022
@ammaralfarsi
Copy link

even unable to unmute. it gets muted again if i try to unmute it

@srodighiero
Copy link
Author

@ammaralfarsi same for me. Workaround in my case is to hold the mute/unmute button for few seconds.

@ammaralfarsi
Copy link

@ammaralfarsi same for me. Workaround in my case is to hold the mute/unmute button for few seconds.

Just tried it and it works when i hold if for few secs.

Thx

@andyp05
Copy link

andyp05 commented Jul 13, 2022

Updated to HA 2022.7 and WebRTC 2.3.1. Cameras work fine with full-screen option on iPhone until I set ui: true
Mute on/off does not work even if I press for seconds.

@keeema
Copy link

keeema commented Dec 16, 2022

For me fullscreen still not working.
Home Assistant 2022.12.6
WebRTC Camera 2.3.1

@AlexxIT
Copy link
Owner

AlexxIT commented Jan 2, 2023

Unfortunately, the iPhone has the worst browser in the world today.
It does not support a lot of modern web technologies. Including MSE and Full screen:
https://caniuse.com/mediasource
https://caniuse.com/fullscreen

PS. No problem on desktop Mac or iPad. Only iPhones...

@AlexxIT AlexxIT closed this as completed Jan 2, 2023
@MStcz
Copy link

MStcz commented Jan 8, 2023

Unfortunately, the iPhone has the worst browser in the world today. It does not support a lot of modern web technologies. Including MSE and Full screen: https://caniuse.com/mediasource https://caniuse.com/fullscreen

PS. No problem on desktop Mac or iPad. Only iPhones...

Hi, I have very same problem also on iPad. When "ui: true" all buttons are gone. I can see them just for short time before the video is loaded.

Home Assistant 2023.1.1
Supervisor 2022.12.1
Operating System 9.4
Frontend 20230104.0
WebRTC-3.0-beta.3
iPadOS 16.2
Home Assistant app on iOS 2022.10.1

@jorisrymenants
Copy link

jorisrymenants commented Jan 13, 2023

Full screen not showing for me on ios iphone 13 pro, ios 16.1.2
controls never show, not when UI: true is set, and not when it is not set
webrtc version: v3.0-beta4

used to work in non v3 versions

@AlexxIT
Copy link
Owner

AlexxIT commented Jan 13, 2023

The iPhone browser does not support this feature

@jason0x43
Copy link

The iPhone browser does not support this feature

WebRTC cards in iPhone Safari do show the normal video controls (play, stop, Airplay, full screen), and native Home Assistant video streams in the iPhone companion app also have the video controls, so videos can show the controls. I don't know off the top of my head what the requirements are for doing so, though.

@AlexxIT
Copy link
Owner

AlexxIT commented Jan 22, 2023

@jason0x43 problem with custom UI. When native controls disabled

@jason0x43
Copy link

Odd that the issue only seems to apply to the iPhone companion app, and not the iPad companion app or Safari on any device.

Interestingly, with WebRTC v3.0.0 I get the custom UI (the PTZ controls, at least) and the native controls in the iPhone companion app, and all of them work.

@AlexxIT
Copy link
Owner

AlexxIT commented Jan 22, 2023

@MStcz custom UI for iPad should be fixed in latest release

@MStcz
Copy link

MStcz commented Jan 27, 2023

@MStcz custom UI for iPad should be fixed in latest release

Hi @AlexxIT, thank you for the update. I can see custom shortcuts, speaker button at the bottom right but not full screen button at the bottom left. Tested on iPad with "ui: true".

Home Assistant 2023.1.7
Supervisor 2023.01.1
Operating System 9.4
Frontend Frontend 20230110.0
WebRTC v3.0.1
iPadOS 16.2
Home Assistant app on iOS 2022.10.1

@haforme
Copy link

haforme commented Feb 3, 2023

I saw that this issue is closed but wanted to advise that the Full Screen Button is missing from iPAD IOS 16.2. Iam running WebRTC version 3.0.2. The Full Screen button appears and works on a PC web browser.

Home Assistant 2023.2.0
Supervisor 2023.01.1
Operating System 9.5
Frontend 20230201.0 - latest

@jason0x43
Copy link

Just for comparison, I'm also running HA 2023.2.0 and WebRTC 3.0.2, and the full screen button does show up on my iPad running iOS 16.2.

@haforme
Copy link

haforme commented Feb 3, 2023

I cleared the cache in the companion app and that did not fix the issues.

Do you have "ui: true" in your webRTC card. I do and the full screen indicator [ ] shows up in the bottom left corner of my PC but nothing for the app. Maybe that is the difference. If I set "ui: false" then I see the arrows that allow me to stretch the screen to full but then other items appear that I do not wish to see.

@jason0x43
Copy link

I have ui: true, and if I tap the video I see both the native controls and the WebRTC UI (the PTZ controls, at least).

IMG_B414E2239363-1

@MStcz
Copy link

MStcz commented Feb 5, 2023

I have ui: true, and if I tap the video I see both the native controls and the WebRTC UI (the PTZ controls, at least).

It is strange. I am able to achieve very same result as you but just with ui: false. In that case each time I open the stream can see pause icon in the middle of the screen and partial opacity over the whole screen - I don 't like it. That 's why I prefer ui: true but there is no full screen mode button/icon.

iPad ui: false after click:
iPad_3d_uif1
Zive Vysilani = Live Broadcast

iPad ui: false:
iPad_3d_uif2

iPad ui: true:
iPad_3d_uit

Laptop ui: true:
LT_3d_uit

Laptop ui: false:
LT_3d_uif

@AlexxIT AlexxIT reopened this Feb 6, 2023
@giantorth
Copy link

Would it be possible to have an option of "ui: supported" and not set custom UI for iOS browsers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.