-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tidy patches into plugins #6
Comments
it already put. See develop branch. I'm build pacman with this changes when I test it. |
Yeah, I know that you already merged the change into msys2-pacman. I meant that the strip plugin is now very big and does various stuff not related to stripping, for example handling executable files without .exe extension (https://github.com/Alexpux/MSYS2-pacman/blob/develop/scripts/libmakepkg/tidy/strip.sh.in#L86-101). Maybe this part of the strip plugin could now be a separate plugin. |
i don't want to split this code because it hard to maintain it. this procedures a get from cygwin build system. |
Could you point me to where you got these procedures? I found only cygbuild, but their code is very different to the one in MSYS2 makepkg. |
https://sourceforge.net/p/cygwin-ports/cygport/ci/master/tree/lib/src_postinst.cygpart Search for "__prepstrip" |
I see there are some big patches for the tidying phase of makepkg. Now that the phase is extendable, maybe some of the MSYS2-specific code should be put into separate files for better maintainability?
The text was updated successfully, but these errors were encountered: