Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Performance for Slow-Path Cases #12

Open
Alexhuszagh opened this issue Oct 31, 2024 · 1 comment
Open

Optimize Performance for Slow-Path Cases #12

Alexhuszagh opened this issue Oct 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Alexhuszagh
Copy link
Owner

Recently, upon a major rewrite of lexical, noticed that although performance for fast_float and fast-float Rust was by far the most performant of any library, for near-halfway cases, especially those with many digits or large exponents, the performance dwindled rapidly. A detailed description can be found in fastfloat/fast_float#93, and a PR to fix the aforementioned issue can be found in fastfloat/fast_float#96.

As with fast_float, I own all the code required, and am willing to submit it under any license, including public domain. It might take me a while to finish the PR, as I am doing some work with other projects and work, but would be more than happy to submit a PR if there is interest.

Related to:
aldanor#32

@Alexhuszagh Alexhuszagh added the enhancement New feature or request label Oct 31, 2024
@Alexhuszagh Alexhuszagh added this to the 0.3.0 milestone Oct 31, 2024
@Alexhuszagh Alexhuszagh self-assigned this Oct 31, 2024
@Alexhuszagh
Copy link
Owner Author

Alexhuszagh commented Jan 11, 2025

Is there interest in this? It's definitely doable but would require a bit of a face lift which I'm not sure if any dependents are interested in. Especially making any major code changes to this.

If there's any interest, particularly by the larger users of fast-float2, I'd be more than happy to contribute these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant