Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should module styles be "reset/zeroed" when there's a style.css available? #3123

Closed
linkert opened this issue Apr 7, 2024 · 2 comments
Closed
Labels
bug Something isn't working custom hyprland

Comments

@linkert
Copy link

linkert commented Apr 7, 2024

I'm fighting the hyprland/workspaces module as it seem to bring a whole lot of styling from outside my control.

Help me understand what's going on here. This aforementioned module seem to have a bunch of border-radius, fade on hover type animation an such. None of it is specified by me — how can I reset all of it? It's messing with the total height of my bar and it's a mess to guess what I need to counteract in order to "reset" the various properties to find out what's building up the total height..

I realize this is not a support forum which is why the point of this issue is to ask the question: should modules default to any styling at all when there's a style.css present under $HOME/.config/waybar/? I'd suggest: yes, they should all default to a stylesheet where all available CSS properties have been zeroed { margin, padding, border, *-radius, et cetera... }: { 0, none }.

To my mind this would make life soooo much simpler — or maybe I just lack CSS-skills :P

Have a good one!

@github-actions github-actions bot added bug Something isn't working custom hyprland labels Apr 7, 2024
@ordy
Copy link
Contributor

ordy commented Apr 7, 2024

Short version: It's inherited from the GTK theme.

Long version: See FAQ, #60 and #2549

Also a reason why most waybar styles.css you can find start with

* {
   padding: 0px;
   margin: 0px;
   border: none;
}

To make sure that we start with a clean layout, but you'll probably still end up having to deal with custom adjustments at some point.

I mean even some elements from HTML come with some built-in CSS 😂

@linkert
Copy link
Author

linkert commented Apr 8, 2024

Short version: It's inherited from the GTK theme.

Long version: See FAQ, #60 and #2549

Also a reason why most waybar styles.css you can find start with

* {
   padding: 0px;
   margin: 0px;
   border: none;
}

To make sure that we start with a clean layout, but you'll probably still end up having to deal with custom adjustments at some point.

I mean even some elements from HTML come with some built-in CSS 😂

EDIT:

Above mentioned along with min-height: 0; did the trick!

Thanks for the reply. Yeah, I've got those properties figured yet there's still more thiccness to specifically workspaces than I'd like there to be and it's probably some property I can set in order to combat this.

2024-04-08T15:38:58,709878725+02:00
2024-04-08T15:39:50,103801972+02:00

@linkert linkert closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working custom hyprland
Projects
None yet
Development

No branches or pull requests

2 participants