Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): fix ldap auth cache by creating authClient on construct in… #41

Closed
wants to merge 2 commits into from

Conversation

kopax
Copy link
Contributor

@kopax kopax commented Jul 25, 2018

Inspired from:

Test: OK

How to test

Use the test release version on npm:

$ npm install -g [email protected]

You will need at least to rename your ldap config in your config.yaml:

auth:
  # Note: to people who want to test it
  # this MUST be the suffix of the module so here it is ldap-node-cache instead of ldap 
 verdaccio-ldap-fixed-cache:
    type: ldap
    client_options:
      cache: true

It is also possible to test with Docker:

FROM verdaccio/verdaccio:3
RUN yarn add [email protected]

Related resources

@kopax
Copy link
Contributor Author

kopax commented Jul 25, 2018

I myself try to test it but unfortunately, I could not log in at all. Can anyone test this? It's been a long time since we are not using this plugin because of its unusable state due to caching absence.

Again, I am now disabling LDAP entirely and I hope contributors here can take a hand.
The code should be working the same for both fixed (#40 and #41), it needs tester.

@Alexandre-io
Copy link
Owner

Thank you for your help, #42 seems to correct the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants