Last row isn't parsed (xls)

[mschindlerMM]

It appears that the XLS parser is not parsing the last line of a sheet. Therefore, neither the count_rows nor the get_rows return the expected value. I have tried several XLS sheets and they are all getting parsed without the last line.

You can even reproduce that with your own test file (exoffice/test/test_data/test.xls). Sheet 1 has 23 rows, but count_rows returns 22. Sheet 2 has 10 rows, but count_rows returns 9.

[AlexKovalevych]

According to these tests everything works fine and the parser returns correct number of lines:

https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice.ex#L85
https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice.ex#L140

Did i miss something?

[mschindlerMM]

Strange. I can only say that the tests mentioned do not return the expected result for me. We tried it on MacOs and Linux - both with the same flawed result.

Not sure what information I can give you that might be useful.

[AlexKovalevych]

I can only say that the tests mentioned do not return the expected result for me

So the tests are not passing on your machine? Since they passed on my machine (linux) and on travis https://travis-ci.org/github/AlexKovalevych/exoffice/builds/687345078 i can only guess why it is so. Maybe otp/elixir version difference or you can try to run them in docker (just to change environment) and see if it works. I've also tried several cases which are not represented in tests - each time they return correct number of lines.

[mschindlerMM]

Seems like it won't work if you use the package as a dependency.

I cloned your repository and tested the parsing there ... and it worked. Then I created a new dummy project and installed the package as a dependency ... and this result was unfortunately wrong again (same thing as already explained in the issue).