Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API GET /backup/list/<local|remote> does not work #291

Closed
zvonand opened this issue Oct 27, 2021 · 0 comments · Fixed by #296
Closed

API GET /backup/list/<local|remote> does not work #291

zvonand opened this issue Oct 27, 2021 · 0 comments · Fixed by #296
Assignees

Comments

@zvonand
Copy link
Contributor

zvonand commented Oct 27, 2021

1.2.0 changelog says:

Added REST API /backup/list/local and /backup/list/remote to allow list backup types separately

However, GET /backup/list/local lists ALL existing backups regardless of their location, and GET /backup/list/remote does not show any backups at all


How to reproduce
Simple environment with docker images for clickhousebackup and pure-ftpd

docker run -d --name ftpd_server -p 21:21 -p 30000-30009:30000-30009 -e "PUBLICHOST=localhost" -e "FTP_USER_NAME=aztest" -e "FTP_USER_PASS=aztest" -e "FTP_USER_HOME=/home/aztest" stilliard/pure-ftpd
docker run  --rm --network host -v "/var/lib/clickhouse:/var/lib/clickhouse" -e REMOTE_STORAGE="ftp" -e FTP_ADDRESS="localhost:21" -e FTP_USERNAME="aztest" -e FTP_PASSWORD="aztest" altinity/clickhouse-backup:1.2.0 server

Create a remote backup:

curl -s -d {"command": "create_remote bp2"}' localhost:7171/backup/actions -X POST

Now, output of GET backup/list and backup/list/local are identical

@Slach Slach self-assigned this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants