Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote_storage: none leads to config validation failure #246

Closed
widders opened this issue Aug 17, 2021 · 2 comments · Fixed by #288
Closed

remote_storage: none leads to config validation failure #246

widders opened this issue Aug 17, 2021 · 2 comments · Fixed by #288
Labels
bug Something isn't working

Comments

@widders
Copy link

widders commented Aug 17, 2021

With remote_storage set to 'none' all functions exit with: "error 'none' is unsupported compression format"

I tracked it to line 201 of config/config.go where the check on remote_storage was removed in commit ab56371
@AlexAkulov
Copy link
Collaborator

Thank you! It will be fixed in next version.

@AlexAkulov AlexAkulov added the bug Something isn't working label Aug 25, 2021
@Slach
Copy link
Collaborator

Slach commented Oct 21, 2021

@widders did you try the latest 1.1.0+ clickhouse-backup release?

I tried to reproduce your issue with following config

general:
  remote_storage: none

clickhouse-backup list and clickhouse-backup list local works ok
all command which related to remote_srorage aborted with properly error message

I close issue, feel free to make comment or reopen if necessary

@Slach Slach closed this as completed Oct 21, 2021
@Slach Slach mentioned this issue Oct 24, 2021
Merged
Slach added a commit that referenced this issue Oct 24, 2021
@Slach
Merge pull request #288 from Altinity/master
8567fc6 
# v1.2.0

INCOMPATIBLE CHANGES
- REST API `/backup/status` now return only latest executed command with status and error message

IMPROVEMENTS
- Added REST API `/backup/list/local` and `/backup/list/remote` to allow list backup types separately
- Decreased background backup creation time via REST API `/backup/create`, during avoid list remote backups for update metrics value 
- Decreased backup creation time, during avoid scan whole `system.tables` when set `table` query string parameter or `--tables` cli parameter     
- Added `last` and `filter` query string parameters to REST API `/backup/actions`, to avoid pass to client long JSON documents
- Improved `FTP` remote storage parallel upload / download
- Added `FTP_CONCURRENCY` to allow, by default MAX_CPU / 2 
- Added `FTP_DEBUG` setting, to allow debug FTP commands
- Added `FTP` to CI/CD on any commit
- Added race condition check to CI/CD

BUG FIXES
- environment variable `LOG_LEVEL` now apply to `clickhouse-backup server` properly
- fix #280, incorrect prometheus metrics measurement for `/backup/create`, `/backup/upload`, `/backup/download`
- fix #273, return `S3_PART_SIZE` back, but calculates it smartly
- fix #252, now you can pass `last` and `filter` query string parameters
- fix #246, incorrect error messages when use `REMOTE_STORAGE=none`
- fix #283, properly handle error message from `FTP` server 
- fix #268, properly restore legacy backup for schema without database name
- fix #287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.2.0
3 participants
@Slach @widders @AlexAkulov