Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The flag called 'Disable Thorium Top Bar Icons' doesn't work properly. #762

Open
rakinosine opened this issue Aug 8, 2024 · 5 comments
Open

Comments

@rakinosine
Copy link

System Details

  • OS: Windows 10
  • Thorium Version: Version 124.0.6367.218 (Official Build) (64-bit)

Problem
Even after enabling the flag called 'Disable Thorium Top Bar Icons' some of the icons are still colorful which include 'Stop loading this page' icon, Extensions icon, Close icon, Incognito icon and so on.

Screenshots
image
image
image

Thanks in advance.

@gz83
Copy link
Collaborator

gz83 commented Aug 8, 2024

This is intentional

@ottozumkeller
Copy link

Maybe add an option for the flag to disable it for all icons? Like "Enable", "Disable", "Disable all".

@rakinosine
Copy link
Author

This is intentional
It looks kind of ugly.

@Alex313031
Copy link
Owner

@rakincw @ottozumkeller I wanna make it disable color on ALL of the top bar icons and the icons in the main menu
However, secondary icons like incognito and "chevron" icons will be left alone. Its because for each icon I want to add to the flag, I have to make a copy of the icon without color, and then add the source code file that manages that icon and add an "if else" statement for the flag. Doing this for all the icons that thorium modifies would be too much work, so I'm mainly concerned about the prominent ones that people see all the time when using the browser.

Also, specificially about the incognito one, I find it useful because if I have a bunch of windows open and a few incognito windows open, it makes it alot easier to identify on either Windows or Ubuntu because I can toggle "overview" mode and it is easy to distinguish the bright red. Otherwise it is hard to tell which is which without manually cycling through all your Thorium windows. And in my case, I am a browser "hypertasker" (which really just means I'm lazy at closing tabs lolol), so I often have up to 10 or more windows open, so it gets annoying.

@shawny43
Copy link

shawny43 commented Oct 8, 2024

Why not just redo the design and create an monochrome. Also, remember browser have themes that modify the color of the browser. Some of color you choose could conflict with the rest color of the UI and being unreadable.

Also, for incognito, purple in monet style could be a nice fit, firefox and other browser use purple pallets to define incognito mode.

I recommend you to look at MD3 with the color pallets to know more, since Chromium is based on this model now.
https://m3.material.io/

Also, maybe if you can code better, just get inspiration of Firefox and seperate incognito window from the main openned app. This could be a nice start to determinate which one is real incognito.

There an example with Zen Browser based on Firefox fork.
image

image

Yes i have to clean-up my taskbar lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants