Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual tabs glitch #156

Closed
dmig opened this issue May 7, 2023 · 8 comments
Closed

Visual tabs glitch #156

dmig opened this issue May 7, 2023 · 8 comments

Comments

@dmig
Copy link

dmig commented May 7, 2023

System Details

  • OS: Ubuntu 23.04
  • Thorium Version 112.0.5615.166 (Official Build) stable, built on Linux (64-bit)

Problem
Line under the tab bar gets a break in the wrong place -- width of pinned tabs is ignored. See screenshots for more details.

Screenshots
Screenshot from 2023-05-07 11-30-38
Screenshot from 2023-05-07 11-30-31
Screenshot from 2023-05-07 11-30-25
Screenshot from 2023-05-07 11-30-13
Screenshot from 2023-05-07 11-30-06
Screenshot from 2023-05-07 11-30-00
Screenshot from 2023-05-07 11-32-51
Screenshot from 2023-05-07 11-32-44
Screenshot from 2023-05-07 11-32-36
Screenshot from 2023-05-07 11-32-29

@Alex313031
Copy link
Owner

@dmig This is related to a patch to enable tab outlines, but the bug is from upstream.

I enabled the patch because especially in lighter themes, it can sometimes be hard to tell what tab is selected.

The fix would be to turn it off, but then you don't get the benefit from it. The better thing would be to wait until upstream fixes it, but IDK when that would be. I could file a bug on it if you want.

@dmig
Copy link
Author

dmig commented May 8, 2023

I see. Is it possible to add a feature flag for this?

@dmitriy-geels
Copy link

The fix would be to turn it off...

@Alex313031 I mean, having a control over this would be nice

@Alex313031
Copy link
Owner

@dmig @dmitriy-geels @yochananmarqos Added in latest release. I re-added these features after chromium removed them, since I really like them in dark mode. While I was re-adding them, I figured I would put them behind a flag.

@dmig
Copy link
Author

dmig commented Jun 4, 2023

Thorium M48: the bug is still there and not dependent on chrome://flags/#tab-outlines-in-low-contrast-themes and chrome://flags/#prominent-dark-mode-active-tab-title

Screenshot from 2023-06-04 22-09-02

@Alex313031
Copy link
Owner

@dmig So you disabled both of those flags and still got this behavior?

What GPU do you have, and are you using X11 or wayland

@dmitriy-geels
Copy link

Intel Cometlake gpu, running X11

@dmig
Copy link
Author

dmig commented Jul 23, 2023

Release 50, bug is still there.

@gz83 gz83 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants