Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello, AlekPet. #64

Open
xingewh opened this issue Jul 3, 2024 · 4 comments
Open

Hello, AlekPet. #64

xingewh opened this issue Jul 3, 2024 · 4 comments

Comments

@xingewh
Copy link

xingewh commented Jul 3, 2024

Hello, AlekPet.
Thank you very much for your plugin. It has conveniently solved the language problems encountered by people in non-English speaking countries when using ComfyUI, which is truly fantastic. However, I have encountered an issue during use. When I input an English prompt or a prompt that includes both English and Chinese directly into the text box, the results displayed by the node are incorrect. Could you please modify the code so that the original English words are retained and only the non-English parts are translated?
Thank you.

345040271-edf65e81-492c-4616-ad7b-b24bd3059db8

@AlekPet
Copy link
Owner

AlekPet commented Jul 3, 2024

Hello, AlekPet.
Thank you very much for your plugin. It has conveniently solved the language problems encountered by people in non-English speaking countries when using ComfyUI, which is truly fantastic. However, I have encountered an issue during use. When I input an English prompt or a prompt that includes both English and Chinese directly into the text box, the results displayed by the node are incorrect. Could you please modify the code so that the original English words are retained and only the non-English parts are translated?
Thank you.

Hello. I probably won’t be able to do anything here and here’s why, because. ArgosTranslator has trained models for different languages
and only the English language has a large list of languages, while others only have English (list https://www.argosopentech.com/argospm/index/), it may also depend on the model, on what data it was trained, hence conclusion. Maybe you should try using a deep translator node.

@AlekPet
Copy link
Owner

AlekPet commented Jul 3, 2024

The only thing I can do is, for example, if the text contains the following tag <<@>> “Длинный текст @Comfyui это сила!@, и еще длинный текст...”, then this text during translation is replaced, for example, by @1@ and it is not translated, and after translation, return the text to the form “Long text Comfyui is power!, and also long text...” 😄

@xingewh
Copy link
Author

xingewh commented Jul 3, 2024

你好,AlekPet。非常感谢您的插件。它方便地解决了非英语国家人们在使用ComfyUI时遇到的语言问题,这真是太棒了。但是,我在使用过程中遇到了问题。当我直接在文本框中输入英文提示或包含英文和中文的提示时,节点显示的结果不正确。您能否修改代码,以便保留原始英语单词,仅翻译非英语部分? 谢谢。

你好。我可能无法在这里做任何事情,这就是原因,因为。ArgosTranslator已经为不同的语言训练了模型,只有英语有大量的语言列表,而其他语言只有英语(列表 https://www.argosopentech.com/argospm/index/),这也可能取决于模型,训练的数据,因此得出结论。也许您应该尝试使用深度翻译器节点。

Hello, AlekPet, my friend. Thank you very much for your reply. After my test today, when I use a proxy server, the translation results are usually accurate. Entering both English and Chinese at the same time also yields satisfactory results. Because, as you know, the network environment in China is somewhat special.
What I don't understand is whether the ArgosTranslator node needs to translate websites during its operation? Or is it running completely locally?
After I downloaded the model file here (https://www.argosopentech.com/argospm/index/), where should I place it? Looking forward to your answer.
After I enabled proxy server to access the Internet, the deep translator node can obtain very good translation results. Thank you.

@AlekPet
Copy link
Owner

AlekPet commented Jul 4, 2024

Hello. In the ArgosTranslator node, when you select a language that is not yet in the system, during generation it downloads the model file for the desired language along the following path (C:\Users\Username\.local\cache\argos-translate\downloads), then it does not have internet needed. Yes, the translation from Argotranslate does not shine with quality 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants