Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output image, size and mask #52

Open
MaraScott opened this issue May 25, 2024 · 3 comments
Open

Output image, size and mask #52

MaraScott opened this issue May 25, 2024 · 3 comments

Comments

@MaraScott
Copy link

image

Hi, thanks for your node, it is super easy to work with.

here 3 point I notice

  • In my screenshot, the output image do not match the canvas version (output pink, canvas blue) the pink version is a previous version.
  • the output size is different from the input see Canvas Size != ImageSize #48 (comment)
  • how to use Mask ? can the mask be the drawing part ?
@AlekPet
Copy link
Owner

AlekPet commented May 26, 2024

Hello. Apparently on the backend side, it doesn’t have time to receive the image, maybe due to hardware or network latency, I’ll see what can be done. It’s strange about the size, because at the input there is only one image and it doesn’t change, when I checked everything was correct, send me the workflow and I’ll take a look. As for the mask, it’s a little more complicated, because... An image comes with input and therefore the node is updated, which leads to the replacement of the image and therefore the mask, you need to turn off update the node in the settings (if the node is not connected, then you don’t need to turn it off).

And:
In console comfyui exist message "Painter_{unique_id}: Failed to get image!" ?

@MaraScott
Copy link
Author

MaraScott commented May 26, 2024

Hi,

thanks for your return

As for the mask, it’s a little more complicated, because... An image comes with input and therefore the node is updated, which leads to the replacement of the image and therefore the mask, you need to turn off update the node in the settings (if the node is not connected, then you don’t need to turn it off).

I tried to turn off in the node settings but nothing really happened.
I noticed now if you put a bridge preview and create a mask the mask is removed because the input is considered different after your node.
Would it be possible to implement a status on your image generation so if nothing changes, you don t re-execute the node image generation ?

as per my expections on your node behavior, would it be possible to do this

767ea78b-3958-4a01-a7dc-4024e83a77da

if you have time feel free to come in Fern discord discord.gg/t28yZEewrp you will find me and we can talk more easily about the node behavior (maybe ?!)

@AlekPet
Copy link
Owner

AlekPet commented May 27, 2024

Hi. On the backend there is a method IS_CHANGE, it restarts the node if there were changes, but on the frontend I did not find a property signaling this, so I added it to the do not generate options. The meaning of the following is that you generated it once, unchecked the update image checkbox and changed the mask (although the generation will increase a little, because the backend is still waiting for a response from the frontend to receive the image). About discord, when you have time :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants