toolbar for EssencePicture editor has several issues

[robinboening]

I spotted several issues when using the icon-links in the EssencePicture editor toolbar. I don't want to flood the issues list even more by adding multiple tickets for each of those issues as they might have become buggy due to the same code changes / PR.

Steps to reproduce

1. Configure an element with EssencePicture and add settings with crop: true and linkable: false
2. Navigate to the page edit view, add the element, assign an image and save the element.
3. reload the entire page edit view (this is important as the first issue I am going to explain below does not appear otherwise)

Expected behavior

1. The icon link for the image cropper should be visually "activated" and it should be functionally clickable
2. The icon link for linking the picture should be visually deactivated and it should not be clickable
3. When opening the overlay for picture properties saving should not return an error. Fixed by Image cropper destroy #2139

Actual behavior

1. The icon link for the image cropper is visually deactivated and is not clickable.
2. The icon link for linking (and removing a link) is not clickable but it is visually "activated".
3. When opening the overlay for picture properties, saving leads to parsererror (a quick bug hunt led me to the Alchemy.ImageCropper.destroy() causing this, called from essence_pictures/update.js.erb). Fixed by Image cropper destroy #2139

System configuration

• Alchemy Version: main branch

[tvdeyen]

1. The icon link for the image cropper is visually deactivated and is not clickable.

This is not a bug, but a feature. See: https://github.com/AlchemyCMS/alchemy_cms/blob/main/app/models/alchemy/essence_picture.rb#L134-L140

Without the image being assigned there is nothing to crop. Also we check if the image is large enough to be cropped at all. The latter is controversial, though.

2. The icon link for linking (and removing a link) is not clickable but it is visually "activated".

Should be easily fixed. PRs welcome

[robinboening]

In the steps to reproduce the issue I missed the part of assigning the image, sorry!

It probably was an issue with the image size, as you said. I can not reproduce it anymore using a large image.

I'll update the issue. It leaves us only with the icon link problem.

[github-actions]

This issue has not seen any activity in a long time.
Please create a pull request with a fix or ask someone of the community if they can help.
This issue will be closed in 7 days if no further activity happens.

[github-actions]

This issue has not seen any activity in a long time.
If the issue described still exists in recent versions of Alchemy,
please open a new issue with. Thanks for reporting.