Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading SVG in picture library fails at thumbnail generation #2097

Closed
robinboening opened this issue May 13, 2021 · 1 comment · Fixed by #2090
Closed

Uploading SVG in picture library fails at thumbnail generation #2097

robinboening opened this issue May 13, 2021 · 1 comment · Fixed by #2090

Comments

@robinboening
Copy link
Contributor

robinboening commented May 13, 2021

Steps to reproduce

Upload a SVG file in the picture library.

Expected behavior

The upload should succeed.

Actual behavior

The progress bar indicates that it failed (turns red). Looking at the logs I can see the thumbnail generation fails during signature creation. Following error is thrown and the new database record for Alchemy::Picture is rolled back. The original svg got uploaded (in my case to S3) though.

NoMethodError undefined method `steps' for #<#<Class:0x00007fa7251f8668>:0x00007fa725731468> in /Users/robin/projects/public/alchemy_cms/app/models/alchemy/picture_thumb/signature.rb:12:in `call'
/Users/robin/projects/public/alchemy_cms/app/models/alchemy/picture_thumb.rb:47:in `block in generate_thumbs!'
/Users/robin/projects/public/alchemy_cms/app/models/alchemy/picture_thumb.rb:42:in `each'
/Users/robin/projects/public/alchemy_cms/app/models/alchemy/picture_thumb.rb:42:in `generate_thumbs!'
/Users/robin/projects/public/alchemy_cms/app/models/alchemy/picture.rb:94:in `block in <class:Picture>'

System configuration

  • Alchemy Version: main branch
  • Rails Version: 6.0
@robinboening robinboening changed the title Uploading SVG in picture library fails Uploading SVG in picture library fails at thumbnail generation May 13, 2021
@tvdeyen
Copy link
Member

tvdeyen commented May 13, 2021

Fixed by #2090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants