Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment shapes should actually be arbitrary filters #1098

Open
DanySK opened this issue Feb 16, 2022 · 0 comments
Open

Deployment shapes should actually be arbitrary filters #1098

DanySK opened this issue Feb 16, 2022 · 0 comments
Assignees

Comments

@DanySK
Copy link
Member

DanySK commented Feb 16, 2022

There is no real reason for shapes to be the only way to determine node contents. Indeed, whether or not some content should be injected is more generally the result of a predicate p of kind (RandomGenerator, Environment, Node) -> Boolean. Current Shapes are just a particular case where this predicate is actually somewhat like: p = { (_, env, node) -> shape.contains(env.getPosition(node)) }.

A more general concept of SubDeploy or ContentFilter should be used instead, with Shapes re-implemented as subclasses.
Also a special ContentFilter could reuse the JSR223 infrastructure and allow for full-fledged scripts to be executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants