New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project style #721

Open

AngeloTadeucci opened this issue Jul 5, 2022 · 0 comments

Collaborator

AngeloTadeucci commented Jul 5, 2022 •

edited

Loading

MapleServer2

Handlers

All must implement LogUnknownMode if they have multiple modes.
All modes must be separated into different methods.
All must be stateless.

Packets

Only use one file per Send/Recv OP.
All modes must have their own method with an enum for the mode byte.

GameDataParser

Don't import MapleServer2 into GameDataParser project.
Metadatas must be readonly or init-only. You can use record for that.

Maple2Storage

Files that can be used by GameDataParser and MapleServer2 should live here. (e. g.: Metadata files)

AngeloTadeucci pinned this issue

Zintixx mentioned this issue

Consistent mode naming and handler/packet name changes #723

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment