Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIImageView extensions do not work sometimes for URL's that redirect #15

Closed
robertjpayne opened this issue Sep 22, 2015 · 1 comment · Fixed by #16
Closed

UIImageView extensions do not work sometimes for URL's that redirect #15

robertjpayne opened this issue Sep 22, 2015 · 1 comment · Fixed by #16
Assignees
Milestone

Comments

@robertjpayne
Copy link
Contributor

Xcode: 7.0
AlamofireImage: 1.1.0

Current around line 324 of UIImageView+AlamofireImage.swift there is this block of code:

                guard let
                    currentRequest = strongSelf.af_activeRequest?.task.currentRequest
                    where currentRequest.URLString == request?.URLString else
                {
                    return
                }

Trying to figure out why facebook profile photos don't load such as https://graph.facebook.com/v2.4/529271840955/picture?type=large turns out this check returns because of a 3XX that then results in a different URL.

Would it be worth generated a UUID rather than using the image url or some way of keeping track of the redirects?

@robertjpayne
Copy link
Contributor Author

Looking further I think all that needs to happen here is task.currentRequest should really be task.originalRequest

@cnoon cnoon closed this as completed in #16 Sep 23, 2015
@cnoon cnoon added this to the 1.1.1 milestone Sep 23, 2015
@cnoon cnoon self-assigned this Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants