Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have questions of logical completion handler #209

Closed
cherishloveyou opened this issue Oct 21, 2016 · 1 comment
Closed

have questions of logical completion handler #209

cherishloveyou opened this issue Oct 21, 2016 · 1 comment
Assignees
Milestone

Comments

@cherishloveyou
Copy link

have questions about the the func af_setImageWithURL's completion handler logic, it before self.image = image. as UIImageView's extension, completion handler is the end of operation

@cnoon
Copy link
Member

cnoon commented Nov 20, 2016

I completely agree @cherishloveyou. I believe this was due to legacy reasons and we never updated the calls once we didn't need to run this prior. I've just pushed up e59d18f which addresses the ordering issue in both the UIButton and UIImageView extensions. It also fixes cases where the request was a duplicate which now calls the completion closure with a requestCancelled AFI error.

Cheers. 🍻

@cnoon cnoon closed this as completed Nov 20, 2016
@cnoon cnoon added this to the 3.2.0 milestone Nov 20, 2016
@cnoon cnoon self-assigned this Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants