This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Arm64 amd64 images #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
suggested changes
Apr 28, 2023
| @@ -20,9 +20,9 @@ runs: | |||
| echo "${{ inputs.docker-auth-token }}" | docker login --username awiciroh --password-stdin | |||
| - name: Build and tag Docker image | |||
| shell: bash | |||
| run: docker build -t awiciroh/ciroh-ngen-image:${{ inputs.github-sha }} -t awiciroh/ciroh-ngen-image-${{ inputs.image-platform }}:latest docker/. | |||
| run: docker build -t awiciroh/ciroh-ngen-image:${{ inputs.github-sha }} -t awiciroh/ciroh-ngen-image:latest-${{ inputs.image-platform }} docker/. | |||
There was a problem hiding this comment.
I think this build step is where you want to use QEMU and then provide the --platform flag to the build so it can build either one...
| steps: | ||
| - name: deploy | ||
| uses: actions/checkout@v2 | ||
| - name: Set up QEMU |
There was a problem hiding this comment.
I don't think buildx is building an actual arm image. Since the build-and-push action runs on ubuntu (amd64), just having QEMU ready isn't enough, buildx has to know to build for that platform and work with QEMU. What is actually happening here is buildx is building for the native platform (amd64) and adding the arm platfrom tag.
|
We wanted image name format as, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create two separate images:
awiciroh/ciroh-ngen-image:latest-arm
awiciroh/ciroh-ngen-image:latest-x86
Closes #51