Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): add vite vue plugins if they are missing #517

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

danielroe
Copy link
Collaborator

@danielroe danielroe commented Apr 13, 2023

Description

resolves #508
related: danielroe/nuxt-vitest#130

In Nuxt we moved the injection of vue plugins to after the hook we are using in histoire. (To allow modules to modify the config for them.) This change adds them to Nuxt's vite plugins if they are missing - so it should be backwards compatible.

(Though we might want to make them peer dependencies?)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@danielroe danielroe requested a review from Akryum April 13, 2023 21:17
@codesandbox
Copy link

codesandbox bot commented Apr 13, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@stackblitz
Copy link

stackblitz bot commented Apr 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 6a10934
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64387179c71c6800088f36f5

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 6a10934
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64387179a65089000898afd3

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 6a10934
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64387179a65089000898afd8

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit 6a10934
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/643871792b38540007e575dc

@Akryum Akryum merged commit d74be72 into main Apr 14, 2023
@Akryum Akryum deleted the fix/vue-plugins branch April 14, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histoire fails with Nuxt 3.3.3, requires @vitejs/plugin-vue to handle .vue files
2 participants