Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add presets (fix #53) #88

Merged
merged 12 commits into from
May 11, 2022
Merged

feat: Add presets (fix #53) #88

merged 12 commits into from
May 11, 2022

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented May 9, 2022

Fix #53

Description

I added the preset as a Histoire controls. Here's how to use it:

<script lang="ts" setup>
import { reactive } from 'vue'

const state = reactive({
  sample: 'Hello World',
})
</script>

<template>
  <Story
    title="HstPresets"
  >
    <HstPresets
      id="my-unique-id"
      :state="state"
    />
  </Story>
</template>

I also refactored a bit the select and update the style to use floating-vue.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the draft label May 9, 2022
@hugoattal hugoattal self-assigned this May 9, 2022
@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 8be23ac
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/627bdac67f2d930008b4df1f
😎 Deploy Preview https://deploy-preview-88--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 8be23ac
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/627bdac6d4a4e90009c6e07e
😎 Deploy Preview https://deploy-preview-88--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 8be23ac
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/627bdac6d9486e000a64c128
😎 Deploy Preview https://deploy-preview-88--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal
Copy link
Collaborator Author

Hey @Akryum, is it possible to access the video/screenshots taken by cypress in the netlify instance?

image

I'm having hard times reproducing those cypress errors in my machine...

image

image

@Akryum
Copy link
Member

Akryum commented May 10, 2022

Yes go to the summary: https://github.com/histoire-dev/histoire/actions/runs/2300494824

@Akryum
Copy link
Member

Akryum commented May 11, 2022

I moved the presets from controls to builtin and changed the UX a little bit (+ a reset to initial button)
image

@hugoattal
Copy link
Collaborator Author

Just learned that VDropdown had a auto-size param 😅... Nice update 🥳 !

@Akryum Akryum merged commit 71ba456 into main May 11, 2022
@Akryum Akryum deleted the preset-control branch May 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State presets
2 participants