Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add documentation (fix #44) #60

Merged
merged 4 commits into from
Apr 4, 2022
Merged

feat: Add documentation (fix #44) #60

merged 4 commits into from
Apr 4, 2022

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented Mar 22, 2022

First step to #44

Description

So I just added a few files for the documentation. Nothing perfect, but it's a start.
It's hidden from the menu now.

Access: https://deploy-preview-60--histoire-site.netlify.app/guide/


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added documentation Improvements or additions to documentation draft labels Mar 22, 2022
@hugoattal hugoattal self-assigned this Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 5516778
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/624a9361285b61000915589a
😎 Deploy Preview https://deploy-preview-60--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 5516778
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/624a9361d410aa00070dc52a
😎 Deploy Preview https://deploy-preview-60--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 5516778
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/624a936134f0f4000866c4f0
😎 Deploy Preview https://deploy-preview-60--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal hugoattal removed the draft label Mar 22, 2022
@hugoattal hugoattal requested a review from Akryum March 22, 2022 23:01
@@ -12,7 +12,7 @@ module.exports = {

nav: [
// { text: 'Guide', link: '/guide/' },
{ text: 'Early access', link: '/guide/' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this? I want the URL to be the same so we don't have to redirect later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there will be a lot of links to this page since Histoire is not public yet, but okay, I'm reversing this!
commit: 8f1ef02

@hugoattal hugoattal requested a review from Akryum March 24, 2022 13:40
@Akryum Akryum merged commit a1a3b3a into main Apr 4, 2022
@Akryum Akryum deleted the documentation branch April 4, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants