fix(svelte): variantState should not be modified by component internal state #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #264
Since
Vue.watch
will useProxy
to wrapper svelte component state value, once component state value changed, the globalvariantState
changed in the same time which will makeapplyState
useless and thewatch
callback not be triggered.We can use
histoire/shared.clone
to cut the relation betweenvariantState
and component internal state.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).