Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wip white label customization #15 #27

Merged
merged 8 commits into from
Feb 17, 2022
Merged

feat: wip white label customization #15 #27

merged 8 commits into from
Feb 17, 2022

Conversation

hugoattal
Copy link
Collaborator

Partial #15

Description

⚠️ This is partially fixing #15 (It's a little late, and I prefer to merge this to avoid conflicts if you decide to work on some things in the meantime, like I had for the title update 😅)

So I added the theme configuration, which looks like this:

theme: {
  title: string
  logo?: {
    square?: string
    light?: string
    dark?: string
  }
  colors?: {
    [key in AvailableColors]?: string
  }
  setupFile?: string
}

Additional context

I dropped the textFont and codeFont settings, as they are usually imported in CSS.
So I added a setupFile that can import CSS (I made an example in histoire.theme.css)

I got a little dragged by the iframe in dark mode. I added a small feature that add the htw-dark class to the html of the iframe.
Also, I fixed flashes between iframe loading.

The missing part is the tailwind colors, which are not (yet) implemented. I still don't know how to do this properly...


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the enhancement New feature or request label Feb 17, 2022
@hugoattal hugoattal requested a review from Akryum February 17, 2022 00:33
@hugoattal hugoattal self-assigned this Feb 17, 2022
@netlify
Copy link

netlify bot commented Feb 17, 2022

❌ Deploy Preview for histoirejs failed.

🔨 Explore the source changes: 47eca28

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoirejs/deploys/620d97e3fd51c800079e545c

@hugoattal hugoattal changed the title White label feat: White label customization (fix #15) Feb 17, 2022
@Akryum
Copy link
Member

Akryum commented Feb 17, 2022

Thanks for the initial implementation, it's great! I'll merge it and then I'll iterate on it. 😉

@Akryum Akryum changed the title feat: White label customization (fix #15) feat: wip white label customization #15 Feb 17, 2022
@Akryum Akryum merged commit 0b89dff into main Feb 17, 2022
@Akryum Akryum deleted the white-label branch February 17, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants