Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve automated PR template #1806

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix: Improve automated PR template #1806

merged 4 commits into from
Sep 26, 2023

Conversation

mathieu-anderson
Copy link
Contributor

@mathieu-anderson mathieu-anderson commented Sep 25, 2023

Below you can see what the template looks like:

Linked issue

n/a

Resolves: #xxxxx

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update (arguably? Automated PR template is CI? Haha!)

What is the current behavior?

The PR template is very sparse and doesn't encourage a detailed approach

What is the new behavior?

New PR template is a little more detailed and easier to "fill in"

Other information:

This is only a suggestion, and we may want something different.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

Mathieu Anderson added 2 commits September 25, 2023 14:11
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
@mathieu-anderson mathieu-anderson added the Housekeeping Task for undefined date label Sep 25, 2023
@mathieu-anderson mathieu-anderson self-assigned this Sep 25, 2023
Signed-off-by: Mathieu Anderson <[email protected]>
@mathieu-anderson mathieu-anderson changed the title Improve automated PR template fix: Improve automated PR template Sep 25, 2023
Signed-off-by: Mathieu Anderson <[email protected]>
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@programmiri programmiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! Thanks ❤️

@programmiri programmiri merged commit c026f31 into main Sep 26, 2023
28 checks passed
@programmiri programmiri deleted the improve-pr-template branch September 26, 2023 08:21
@muralibasani
Copy link
Contributor

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Task for undefined date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants