fix(coral): Make all env available when using prefix in ACL request #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Anderson <[email protected]>
mathieu-anderson
added
bug
roope-kar
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
#1119 introduced a "smarter" environment Select input in ACL forms. The available environments will be enabled or disabled depending on the topic chosen. However, when choosing the
PREFIXEDpattern type, all environments would be disabled and render a wrong state, because the prefix may not be === an existing topic name.Screen.Recording.2023-05-10.at.17.07.03.mov
The fix
In regards to how the
PREFIXEDoption is used, we should allow all environments to be chosen in this case.Screen.Recording.2023-05-10.at.17.08.13.mov