Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowplow config #153

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Update snowplow config #153

merged 4 commits into from
Nov 1, 2023

Conversation

programmiri
Copy link
Contributor

Description

While Docusarus generates static HTML files, it uses client-site routing for a smoother experience. That's why we have to call the page view tracking on every route change.

see:

Note

  • this PR also fixes a prop-type

@programmiri programmiri force-pushed the update-snowplow-config branch from 807cb68 to c42ad26 Compare November 1, 2023 09:04
Copy link

cloudflare-workers-and-pages bot commented Nov 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f6efc1
Status: ✅  Deploy successful!
Preview URL: https://f1e9452d.klaw-docs.pages.dev
Branch Preview URL: https://update-snowplow-config.klaw-docs.pages.dev

View logs

Signed-off-by: Mirjam Aulbach <[email protected]>
aindriu-aiven
aindriu-aiven previously approved these changes Nov 1, 2023
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested too!

@programmiri programmiri force-pushed the update-snowplow-config branch 3 times, most recently from d520336 to 1f6efc1 Compare November 1, 2023 10:38
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@programmiri programmiri merged commit 8bad411 into main Nov 1, 2023
4 checks passed
@programmiri programmiri deleted the update-snowplow-config branch November 1, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants