Update settings_sec.htm for buttons placment and warning text ( Cosmetic change ) #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove changes to platformio.ini otherwise it is good to go. |
|
Sure I will do that , i am just testing with someone for another thing and will be done in a bit |
softhack007
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
I agree with @blazoncek - change looks good (and well spotted 👍 ).
Please undo changes to platformIO.ini, then the PR should be good to merge.
|
@blazoncek @softhack007 I have undone changes to platformIO.ini . |
|
By "undo changes", I'd prefer those commits removed from the PR branch entirely. Whatever unrelated things you were testing do not belong in the version history for this PR. It's OK to force push the branch for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the warning text and Backup presets button misalignment in settings_sec.htm .
Before and after view below . PC browser tested are firefox , chrome and edge . Phone tested are Iphone7 and Iphone10
This is a cosmetic change but may lead to confusion otherwise