Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #21

Open
sbernard31 opened this issue Aug 29, 2019 · 2 comments
Open

Improve logging #21

sbernard31 opened this issue Aug 29, 2019 · 2 comments

Comments

@sbernard31
Copy link
Contributor

sbernard31 commented Aug 29, 2019

This issue aims to centralize all possible amelioration about current logging facilities (#22):

  • use the python logging facilities instead of print
  • logging level should also impact python output (not only bpf one)
  • currently in log we only show MAC/IP, maybe it would make more sense to show MAC/IP:port
    when possible.
  • add support of syslog, maybe using sysloghandler
  • bpf log could show if packet is DROP, PASS, TX.
  • use macro for bpf logging instead of if to improve performance ? we should first find a way to measure performance !
@oliwer
Copy link
Contributor

oliwer commented Aug 29, 2019

Also, we will need to send the production logs to Loggly using syslog. It should be easy to add a "SyslogHandler" to the python logger.

@sbernard31
Copy link
Contributor Author

Also, we will need to send the production logs to Loggly using syslog. It should be easy to add a "SyslogHandler" to the python logger.

I add it to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants