Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify management points calculation #38

Merged
merged 5 commits into from
Nov 21, 2019
Merged

Modify management points calculation #38

merged 5 commits into from
Nov 21, 2019

Conversation

yuki-nmi
Copy link
Contributor

Calculation for management points were adjusted.

  • A separate table is made for mais
  • The list of management is adjusted according to Van de Wal et al 2016. (See Factsheet Bodembeheer 0.5 for details)
  • M_M4 is not used anymore, so it is removed from the argument of the function 'calc_management'.
  • Maximum score in the function 'ind_management' is adjusted.

@yuki-nmi yuki-nmi requested a review from SvenVw November 19, 2019 13:49
SvenVw
SvenVw requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@SvenVw SvenVw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for calc_winderodebility fails

@SvenVw
Copy link
Member

SvenVw commented Nov 21, 2019

Updating with master fixes the testing

@SvenVw SvenVw merged commit 13f0142 into master Nov 21, 2019
@SvenVw SvenVw mentioned this pull request Nov 29, 2019
Merged
@SvenVw SvenVw deleted the yuki_management_modify branch December 6, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvenVw SvenVw SvenVw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-nmi @SvenVw