Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuki sulpher #26

Merged
merged 14 commits into from
Oct 21, 2019
Merged

Yuki sulpher #26

merged 14 commits into from
Oct 21, 2019

Conversation

yuki-nmi
Copy link
Contributor

Some B_LG_CBS x B_B_AK combinatoins miss 'clust' values (which determines 'benodigde S uit grond en bemesting (‘slv_av’)'. This results NA values for I_C_S. Clust numbers need to be assigned to all combinations.

@SvenVw
Copy link
Member

SvenVw commented Oct 16, 2019

Combinations of soil type and region that do not exists in table 6.2 of Handboek Bodem & Bemesting are now solved by using the average value of the soil type and ignoring the region

@SvenVw
Copy link
Member

SvenVw commented Oct 16, 2019

The evaluation of I_C_S for arable should not be changed. An sbal of larger than 0 should always give an ind of 1, because no fertilization is needed anymore as the soil delivers enough S for that crop

@SvenVw
Copy link
Member

SvenVw commented Oct 16, 2019

@yuki-nmi shall we merge this PR?

@yuki-nmi
Copy link
Contributor Author

I am still doubting to use the abrupt shift of I_C_S from 0 to 1 for arable land. Theoretically it's true that S availability is enough whtn sbal > 0. However, sbal is derived from a continuous variable SLV and several other constants from lookup table, and a slight change in SLV can results in either I_C_S =1 or I_C_S = 0. This sounds like an artifact.

@SvenVw SvenVw marked this pull request as ready for review October 21, 2019 08:02
@SvenVw
Copy link
Member

SvenVw commented Oct 21, 2019

I changed the evaluation funtion to a logistic one to get a more smooth transition

@SvenVw SvenVw merged commit d4283e8 into master Oct 21, 2019
@SvenVw SvenVw mentioned this pull request Oct 21, 2019
@SvenVw SvenVw deleted the yuki_sulpher branch October 22, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants