Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation for nitrogen #2

Merged
merged 10 commits into from
Jul 12, 2019
Merged

Add evaluation for nitrogen #2

merged 10 commits into from
Jul 12, 2019

Conversation

SvenVw
Copy link
Member

@SvenVw SvenVw commented Jul 10, 2019 •
edited
Loading

First PR #1 should be merged before this PR

@SvenVw SvenVw self-assigned this Jul 10, 2019
@SvenVw
Copy link
Member Author

SvenVw commented Jul 10, 2019

afbeelding

@SvenVw SvenVw requested a review from gerardhros July 10, 2019 10:07
@SvenVw SvenVw marked this pull request as ready for review July 11, 2019 06:54
gerardhros
gerardhros reviewed Jul 11, 2019
View reviewed changes
R/nitrogen.R Outdated Show resolved Hide resolved
gerardhros
gerardhros reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@gerardhros gerardhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see few comments made in the script

@SvenVw SvenVw requested a review from gerardhros July 12, 2019 11:44
gerardhros
gerardhros approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@gerardhros gerardhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SvenVw SvenVw merged commit 5426649 into master Jul 12, 2019
@SvenVw SvenVw deleted the add-n branch July 24, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardhros gerardhros gerardhros approved these changes

Assignees

@SvenVw SvenVw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvenVw @gerardhros