Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Invitation Specs #878

Closed
0xpatrickdev opened this issue Nov 27, 2023 · 4 comments · Fixed by #999
Closed

Document Invitation Specs #878

0xpatrickdev opened this issue Nov 27, 2023 · 4 comments · Fixed by #999
Assignees

Comments

@0xpatrickdev
Copy link
Member

As a developer, I should be able to learn about Invitation Specs and design patterns for communicating offers to and from a smart-wallet.

invitationSpec: {
  source: 'contract' | 'agoricContract' | 'purse' | 'continuing';
  instancePath: [ string ];
  callPipe: [];
  invitationMakerName:  [ string ];
  previousOffer: string;
  invitationArgs: [];
  description: string;
  publicInvitationMaker: string;
}
@0xpatrickdev
Copy link
Member Author

Also see Agoric/agoric-sdk#8082

@0xpatrickdev 0xpatrickdev self-assigned this Dec 4, 2023
@0xpatrickdev
Copy link
Member Author

See #667 for the original issue

@dckc
Copy link
Member

dckc commented Jan 16, 2024

@erights asked about "call pipe"

call pipe is a poor-man's expression language used to encode things like E(E(vaultFactory).getCollateralManager(atomBrand)).makeVaultInvitation()

see AgoricContractInvitationSpec https://github.com/Agoric/agoric-sdk/blob/master/packages/smart-wallet/src/invitations.js#L25

I'm struggling to find tests. I think they use this utility...

https://github.com/Agoric/agoric-sdk/blob/6e90d9640a7129584540b2028198e92a7b6e32c4/packages/inter-protocol/src/clientSupport.js#L88-L95

    invitationSpec: {
      source: 'agoricContract',
      instancePath: ['VaultFactory'],
      callPipe: [
        ['getCollateralManager', [collateralBrand]],
        ['makeVaultInvitation'],
      ],
    },

@dckc dckc mentioned this issue Mar 15, 2024
11 tasks
@dckc dckc closed this as completed in #999 Mar 15, 2024
@dckc
Copy link
Member

dckc commented Mar 15, 2024

oops... I merged the invitation spec docs that I added to #999 on governance without review, didn't I?

@0xpatrick @turadg @sam @Hibbert showed interest at various times.

Please see InvitationSpec Usage under Specifying Offers.

@0xpatrickdev 0xpatrickdev assigned dckc and unassigned 0xpatrickdev Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants