Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence lint warnings in cosmos-sdk #9034

Closed
JimLarson opened this issue Mar 5, 2024 · 1 comment
Closed

Silence lint warnings in cosmos-sdk #9034

JimLarson opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
agoric-cosmos enhancement New feature or request good first issue Good for newcomers hygiene Tidying up around the house

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

Voluminous lint errors in agoric-labs/cosmos-sdk prevent us from seeing new real errors in our fork's code.

Description of the Design

Our current cosmos-sdk base - v0.46.16 - shows thousands of errors in a golangci-lint run, so we'll need to wait for these to be fixed in upstream releases. However, we can eliminate errors in our fork code.

To avoid unnecessary merge conflicts, we'll fix errors in modified files only when the surrounding code fixes the error, e.g. dealing with moved Int or Wrapf().

Security Considerations

Fewer lint messages will make vulnerabilities more visible.

Scaling Considerations

N/A

Test Plan

N/A

Upgrade Considerations

To avoid unnecessary merge conflicts, we'll fix errors in modified files only when the surrounding code fixes the error, e.g. dealing with moved Int or Wrapf().

@JimLarson JimLarson added enhancement New feature or request good first issue Good for newcomers agoric-cosmos labels Mar 5, 2024
@JimLarson JimLarson self-assigned this Mar 5, 2024
@JimLarson JimLarson added the hygiene Tidying up around the house label Mar 5, 2024
@ivanlei ivanlei assigned ivanlei and unassigned JimLarson Apr 26, 2024
@ivanlei
Copy link
Contributor

ivanlei commented Jun 15, 2024

This issue is written with a plan to wait for upstream to complete the work. This isn't actionable.

@ivanlei ivanlei closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos enhancement New feature or request good first issue Good for newcomers hygiene Tidying up around the house
Projects
None yet
Development

No branches or pull requests

2 participants