Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake in liveslots-real-gc test #8883

Closed
mhofman opened this issue Feb 9, 2024 · 3 comments · Fixed by #8941
Closed

Flake in liveslots-real-gc test #8883

mhofman opened this issue Feb 9, 2024 · 3 comments · Fixed by #8941
Assignees
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes test

Comments

@mhofman
Copy link
Member

mhofman commented Feb 9, 2024

Describe the bug

We've been seeing a few flakes in merge CI in the past couple days, in the GC syscall.dropImports test

To Reproduce

CI? Not sure if the flake triggers locally

Expected behavior

No error

Platform Environment

CI / master

Screenshots

not ok 59 - liveslots-real-gc › GC syscall.dropImports %ava-dur=36ms
  ---
    name: AssertionError
    assertion: falsy
    operator: '!'
    values:
      'Value is not falsy:': 'Object @Alleged: undefined {}'
    at: 'packages/swingset-liveslots/test/test-liveslots-real-gc.js:136:5'
@mhofman mhofman added bug Something isn't working test liveslots requires vat-upgrade to deploy changes labels Feb 9, 2024
@mhofman
Copy link
Member Author

mhofman commented Feb 14, 2024

Unfortunately #8910 didn't fix the issue.
New failure after it landed: https://github.com/Agoric/agoric-sdk/actions/runs/7896729757/job/21551266273#step:25:103

@turadg
Copy link
Member

turadg commented Feb 14, 2024

@mhofman
Copy link
Member Author

mhofman commented Feb 14, 2024

Ok, I'm running out of ideas. @warner are you aware to any changes to liveslots or dependencies that happened circa Feb 8 / 9?

I also fail to understand why this specific test fails but not the other very similar ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants