Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodeterministic tests in cosmos-sdk #8612

Closed
JimLarson opened this issue Dec 5, 2023 · 1 comment
Closed

Nodeterministic tests in cosmos-sdk #8612

JimLarson opened this issue Dec 5, 2023 · 1 comment
Assignees
@JimLarson
Labels
agoric-cosmos bug Something isn't working

Comments

@JimLarson
Copy link
Contributor

JimLarson commented Dec 5, 2023 •
edited by michaelfig
Loading

Describe the bug

Some agoric-labs/cosmos-sdk tests experience nondeterministic failures.

See comment in agoric-labs/cosmos-sdk#342 (with proposed patch)

The fix should be upstreamed to cosmos/cosmos-sdk

To Reproduce

CI tests for agoric-labs/cosmos-sdk

Expected behavior

Tests should be deterministic.

Platform Environment

All
@JimLarson JimLarson added bug Something isn't working agoric-cosmos labels Dec 5, 2023
@JimLarson JimLarson self-assigned this Dec 5, 2023
@JimLarson JimLarson mentioned this issue Dec 5, 2023
Merged
19 tasks
@michaelfig
Copy link
Member

Upstream Cosmos SDK has worked around the problem by running all of coin_test.go's test suite serially. So we don't need to do anything here except rerun CI if it breaks, and expect the flake to go away in a future version.

@michaelfig michaelfig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimLarson JimLarson

Labels
agoric-cosmos bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelfig @JimLarson