Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need endo release, update agoric-sdk to depend on that release #7090

Closed
erights opened this issue Feb 28, 2023 · 3 comments · Fixed by #7273
Closed

Need endo release, update agoric-sdk to depend on that release #7090

erights opened this issue Feb 28, 2023 · 3 comments · Fixed by #7273
Assignees
Labels
bug Something isn't working vaults_triage DO NOT USE
Milestone

Comments

@erights
Copy link
Member

erights commented Feb 28, 2023

We have a large overhang of code in agoric-sdk which is redundant with code in recent endo. Once updated, we could remove the redundancy and the hazards of divergence.

See

Speedups we may need that are also blocked on this:

Debugging support we need, that's blocked on this:
endojs/endo#1513 (though see #7270 )

cc @ivanlei

@erights erights added the bug Something isn't working label Feb 28, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 28, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Mar 2, 2023
@turadg
Copy link
Member

turadg commented Mar 6, 2023

Once sdk has the latest Endo, we won't need this makeTypeGuards function in /internal: https://github.com/Agoric/agoric-sdk/pull/6866/files#diff-34f00c7262c12fbaede03f8adf5cc087fa139380893014d57aba98294ebba1feR4

Closing this issue should include changing that guard definition to be like the others.

@michaelfig
Copy link
Member

Once sdk has the latest Endo, we won't need this makeTypeGuards function in /internal:
Closing this issue should include changing that guard definition to be like the others.

I'm not sure why that is the case. Do you mean moving that definition out of @agoric/internal, or that @agoric/internal can take a hard dependency on @endo/patterns, or something else?

@turadg
Copy link
Member

turadg commented Mar 7, 2023

that @agoric/internal can take a hard dependency on @endo/patterns

that's what I had in mind. @agoric/internal shouldn't depend on other @agoric/ package but it's fine to depend on anything in @endo/. It already depends on three.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants