Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include deliverynum/syscallnum in anachrophobia errors #6592

Open
warner opened this issue Nov 18, 2022 · 0 comments
Open

include deliverynum/syscallnum in anachrophobia errors #6592

warner opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request SwingSet package: SwingSet vaults_triage DO NOT USE

Comments

@warner
Copy link
Member

warner commented Nov 18, 2022

What is the Problem Being Solved?

Investigating #6588 would be easier if the error we displayed included both the deliveryNum and the syscallNum of the mismatch. Even better would be more context: include the previous few syscalls actually made, and the previous/next few syscalls expected. Like a diff --unified instead of just the first line of a regular diff.

Description of the Design

Change vat-loader/transcript.js to show more information.

Security Considerations

none, the transcript is common knowledge, and the messages are only displayed on stderr (and the kernel panics immediately afterwards)

Test Plan

A unit test would be nice, but I don't think we currently exercise this error pathway very much.

@warner warner added enhancement New feature or request SwingSet package: SwingSet labels Nov 18, 2022
@warner warner self-assigned this Nov 30, 2022
@ivanlei ivanlei added the vaults_triage DO NOT USE label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

2 participants