Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test upgrade of PSM #6006

Closed
Chris-Hibbert opened this issue Aug 19, 2022 · 4 comments
Closed

Test upgrade of PSM #6006

Chris-Hibbert opened this issue Aug 19, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol test
Milestone

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The PSM is reachably durable. For higher reliability, we should write an upgradeTest like the one for coveredCall.

For bonus points, also write an upgrade tests showing that the PSM can be restart from just balance information.

Description of the Design

see upgradeCoveredCall test

Security Considerations

This would give us more confidence in the PSM.

Test Plan

as above.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Inter-protocol Overarching Inter Protocol pso test labels Aug 19, 2022
@Chris-Hibbert Chris-Hibbert added this to the Mainnet 1 RC0 milestone Aug 19, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Aug 19, 2022
@dckc
Copy link
Member

dckc commented Aug 28, 2022

oops; I closed #5928 assuming this issue was about an end-to-end test of upgrading PSM. How about we include that in the test plan here?

@Tartuffo
Copy link
Contributor

This should be about end-to-end testing. E.g. on a running blockchain, BLD holders vote for it, etc.

@Chris-Hibbert
Copy link
Contributor Author

here's my rough sketch of what an E2E test would look like.

  • boot chain
  • trade on PSM
  • examine metrics
  • set up committee
    • Make voters
    • get charter facet
  • install PSM V2
  • invoke upgrade vote
    • specify param values
  • trade again
  • validate metrics

Committee voting is not yet integrated with SmartWallet, so we'll start with proof of concept via unit tests.

In order to build this we need

  • PSM V2 with vivify
  • PSM Charter
    • govern upgrade, params, no APIs, pause

@Chris-Hibbert
Copy link
Contributor Author

This issue presumed upgrade would be controlled by JS-level governance. The current plan is that upgrade is under the control of cosmos-level votes. This issue is obsolete in favor of #6099.

@Tartuffo Tartuffo added this to the Mainnet 1 RC0 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol test
Projects
None yet
Development

No branches or pull requests

3 participants