deprecate and remove use of creatorInvitation as a legal return value from contracts

[Chris-Hibbert]

What is the Problem Being Solved?

creatorInvitation as a return value from Zoe contracts is redundant. That functionality can be supplied from the creatorFacet.

Description of the Design

Deprecate it. remove all uses, stop supporting it.

Security Considerations

No security implications as long as we do the multi-step deprecation dance to propitiate the chaos gods.

Test Plan

Standard deprecation approach.

[samsiegart]

A use-case where we couldn't replace creatorInvitation with creatorFacet was the NFT ticketing bounty. We wanted the person who instantiated the contract to be able to access some admin functionalities from the dapp frontend. To do this, we deposited the creatorInvitation in their wallet when the contract was deployed, then used the continuing invitation pattern to expose admin functionality in a way compatible with the wallet contract. The wallet contract currently has no way to hold onto, or create offers from a creatorFacet.

The only way for a person to use creatorFacet currently is to persist it in an off-chain ag-solo, which does not have the same persistence guarantees or ease of access as the wallet contract.

[samsiegart]

Assuming we eventually devise some method to deploy a contract through the smart wallet, it's possible that work will include figuring out a way to store the and access the creatorFacet from the smart wallet as well, so my above concerns might be moot.

[dckc]

@Chris-Hibbert @erights is there more than just redundancy that's problematic about creatorInvitation?
I have a vague memory about upgrade or something.