Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain ACKs publish bundle #5460

Closed
mhofman opened this issue May 28, 2022 · 0 comments · Fixed by #5541 or #6039
Closed

Chain ACKs publish bundle #5460

mhofman opened this issue May 28, 2022 · 0 comments · Fixed by #5541 or #6039
Assignees
Labels
agoric-cli package: agoric-cli bug Something isn't working
Milestone

Comments

@mhofman
Copy link
Member

mhofman commented May 28, 2022

Describe the bug

The publishBundle provided by agoric-cli in the deployPowers (added in #4975) seem to not handled errors correctly:

  • The publish can fail with an account sequence mismatch error, and there is no retry logic
  • The publishBundle seem to be fire and forget, claiming success even in the presence of errors

To Reproduce

Steps to reproduce the behavior:

  1. Checkout https://github.com/Agoric/testnet-load-generator/tree/mhofman/publish-bundle
  2. Run the loadgen: SDK_SRC=/path/to/agoric-sdk ./start.sh

Expected behavior

Successful loadgen

Additional context

@kriskowal mentions that we should handle both failures of sending the bundle to the chain, and failure of the bundle to be installed on the chain.

Screenshots

agoric: deploy: /workspaces/agoric/agoric-sdk/golang/cosmos/build/agd tx swingset install-bundle --gas auto --gas-adjustment 1.2 --home /workspaces/agoric/testnet-load-generator/_agstate/agoric-servers/local-solo-8000/ag-cosmos-helper-statedir --keyring-backend test --from ag-solo --chain-id agoric --yes @/tmp/agoric-cli-bundle--21515-uAC3PJ5CCakJ/bundle.json
Error: rpc error: code = InvalidArgument desc = account sequence mismatch, expected 14, got 13: incorrect account sequence: invalid request
Usage:
  agd tx swingset install-bundle <JSON>/@<FILE>/- [flags]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cli package: agoric-cli bug Something isn't working
Projects
None yet
3 participants