-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-time price updates in AMM UI #5019
Comments
This does not have to block launch. @samsiegart can you revisit the estimate on this one? Don't we already get state from notifiers, and this is just one more notification to render? |
@Tartuffo Currently the UI gets the price by polling the contract for the total liquidity for each asset in the pool and calculating the exchange rate from that. It only updates when you select different assets. It's my understanding that Currently there's some bugs/crashes around the aforementioned logic, so I'll need to rewrite that code anyway. The estimate I believe is accurate because of those bugs, and there may be some nuance to iron out around debouncing price updates while the user is changing inputs. |
#4648 should provide the relevant notifier |
To be explicit, we need the notifier for |
The AMM needs to be able to update the price of swaps from a notifier in real-time
The text was updated successfully, but these errors were encountered: