Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Governance to change Liquidation contract in Vaults #3865

Closed
Chris-Hibbert opened this issue Sep 21, 2021 · 4 comments
Closed

Enable Governance to change Liquidation contract in Vaults #3865

Chris-Hibbert opened this issue Sep 21, 2021 · 4 comments
Assignees
@Chris-Hibbert
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival Vaults VaultFactor (née Treasury)
Milestone
Mainnet 1 RC0

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The LiquidationStrategy used in the treasury can be specified in the terms. Currently there is only one implementation, and the choice is made when the contract is started. This should be under the control of governance.

Description of the Design

Even without actually adding a second Liquidation implementation, it would be valuable to make the choice of contract be subject to governance. The current ContractGovernor supports parameters that specifies installations, so adding this to the governedParams would be straightforward.

Security Considerations

Governance could make bad choices.

Test Plan

The usual
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Small Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol Governance Governance labels Sep 21, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone Sep 21, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 21, 2021
@Chris-Hibbert Chris-Hibbert mentioned this issue Sep 21, 2021
Closed
26 tasks
@Tartuffo Tartuffo added MN-1 restival to be done before RUN Protocol Purple Team festival labels Jan 21, 2022
@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@Tartuffo Tartuffo removed this from the Beta Phase 4: Governance milestone Feb 8, 2022
@Tartuffo
Copy link
Contributor

@dtribble Did you start working on this? @Chris-Hibbert seems to think that you did.

@Tartuffo
Copy link
Contributor

@dtribble is working on the new liquidation contract (#4568). This issue is about being able to CHANGE the liquidation contract via Governance.

@Chris-Hibbert Chris-Hibbert added the Vaults VaultFactor (née Treasury) label Mar 10, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@Chris-Hibbert Chris-Hibbert changed the title Enable Governance to change Liquidation contract in Treasury Enable Governance to change Liquidation contract in Vaults Mar 30, 2022
@Tartuffo Tartuffo removed the Small label Apr 8, 2022
@Tartuffo
Copy link
Contributor

@dtribble I believe this is not necessary for RUN Protocol Review, please confirm.

@Chris-Hibbert
Copy link
Contributor Author

closed by #5211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
Mainnet 1 RC0
Development

No branches or pull requests
3 participants
@dckc @Tartuffo @Chris-Hibbert