Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve/audit liveslots virtual-collections tests #10003

Open
warner opened this issue Aug 30, 2024 · 1 comment
Open

improve/audit liveslots virtual-collections tests #10003

warner opened this issue Aug 30, 2024 · 1 comment
Labels
enhancement New feature or request liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Aug 30, 2024

What is the Problem Being Solved?

One consequence of bug #8756 was that using a collection after doing collection.clear() did not keep working correctly: .has(oldkey) reported true, .init(oldkey, newvalue) failed.

In the PR for the fix (#9961), I updated the tests to exercise the cases that were failing before. But the fact that the existing tests did not catch this means that we should probably take a critical look at those tests, and make sure they're covering everything we can think of.

The tests live in https://github.com/Agoric/agoric-sdk/blob/master/packages/swingset-liveslots/test/collections.test.js

@warner warner added enhancement New feature or request SwingSet package: SwingSet liveslots requires vat-upgrade to deploy changes labels Aug 30, 2024
@warner
Copy link
Member Author

warner commented Aug 31, 2024

#10007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

1 participant