Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Can't make this work in iOS #14

Open
renanpupin opened this issue Dec 6, 2018 · 14 comments
Open

Can't make this work in iOS #14

renanpupin opened this issue Dec 6, 2018 · 14 comments
Assignees

Comments

@renanpupin
Copy link

Can we have a detailed documentation to explain how to setup AgoraIO-RNSDK?
I tried to install the iOS SDK at my project following the instructions and it did not work.
Also I tried to clone the repository and compile with the AgoraRtcEngineKit.framework but got some errors.
.../React-Native-SDK/node_modules/react-native/third-party/glog-0.3.4/src/base/mutex.h:105:10: 'config.h' file not found.

I would appreciate if someone can help.

Thanks!

@CavanSu
Copy link
Contributor

CavanSu commented Dec 7, 2018

I have same problem after I update xcode 10. But this issue can workaround. First remove old "React-Native-SDK/node_modules" . after you can cd to "React-Native-SDK/node_modules/react-native/scripts", and run "./ios-install-third-party.sh" to replace "npm install". Finally, use xcode run sample app.

@renanpupin
Copy link
Author

It seems to be not the right solution, but a workaround.
I would like to ask if Agora.io team have plans to support react-native in the right way, because our team is using another third-party library to make videocalls but we pretend to migrate to Agora.io library.
Also I can suggest the right way to provide native libraries to react-native described by the React-native core team at this link.
https://facebook.github.io/react-native/docs/native-modules-setup
https://facebook.github.io/react-native/docs/linking-libraries-ios

Thanks.

@renanpupin
Copy link
Author

Anyway would be nice if we have a sample project with basic configurations.

@renanpupin
Copy link
Author

@CavanSu if I remove"node_modules" I can't access "React-Native-SDK/node_modules/react-native/scripts"

@CavanSu
Copy link
Contributor

CavanSu commented Dec 9, 2018

sorry, i forget this step that you need to "nmp install" again after you remove old "React-Native-SDK/node_modules".

Whole steps:

  1. remove old "React-Native-SDK/node_modules"
  2. nmp install
  3. cd to "React-Native-SDK/node_modules/react-native/scripts", and run "./ios-install-third-party.sh"
  4. use xcode run sample app

@renanpupin
Copy link
Author

Still not working. :(
@CavanSu could you please create an example with the integrated SDK that I can clone and just test?
Thanks.

@plutoless
Copy link
Contributor

@renanpupin thanks for the post. upgrade react-native lib version to 0.56.0 makes it work for me. if you want to keep current version, you may read the top rated post in this post https://stackoverflow.com/questions/50836558/react-native-config-h-not-found to manually make install the config.h file.

@renanpupin
Copy link
Author

Can't make this work on 0.56.

Again, I suggest the right way to provide native libraries to react-native described by the React-native core team at this links.

https://facebook.github.io/react-native/docs/native-modules-setup
https://facebook.github.io/react-native/docs/linking-libraries-ios

Can we have a sample app with everything configurated and the binaries provided as a RN library?

@plutoless
Copy link
Contributor

@renanpupin I'm sorry but there's no recent plans to make big changes to this repo.
if you would like to do similar things like react-native link xxx, you may take a look at this repo. https://github.com/syanbo/react-native-agora i believe they are already doing things in the native way as you described.

@plutoless
Copy link
Contributor

@renanpupin if you can also try this workaround.
facebook/react-native#20774
hope this helps you fix your problem.

@daino3
Copy link

daino3 commented Feb 18, 2019

Can you at least update the documentation to reflect the actual steps involved to use this SDK with an iOS project? Otherwise, I would dumpster fire this repo.

@plutoless
Copy link
Contributor

@daino3 i'm sorry for the inconvenience caused. we are preparing a new version of our RN sdk already. Together we will take in your advice and provide how to integrate with existing project guide. This should be available within this week.

@daino3
Copy link

daino3 commented Feb 21, 2019

@plutoless - sorry, my response was a little dramatic. I would just love some better documentation on integrating the SDK within a project.

@plutoless
Copy link
Contributor

hi @daino3 , we have published the new version to npm
https://www.npmjs.com/package/react-native-agora
And we have this quickstart guide designed for this npm version.
https://github.com/AgoraIO-Community/Agora-RN-Quickstart

Note the sample run guideline still refers to setting up a new project. But integrating within existing project is most likely the same, 1. npm install 2. react-native link 3. run pod install and react-native run-xx.
We are still arranging the docs to integrate from existing project, and we will publish it as soon as it's done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants